[ 
https://issues.apache.org/jira/browse/TIKA-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906352#action_12906352
 ] 

Staffan Olsson commented on TIKA-482:
-------------------------------------

I've looked through your commits briefly but haven't had time to merge it into 
my branch yet.

I couldn't spot the difference in Exif Date/Time, what is it?

A test seems to be missing, namely 
http://github.com/solsson/tika/blob/trunk/tika-parsers/src/test/java/org/apache/tika/parser/image/ImageMetadataExtractorTest.java

I'm working on adding real XMP extraction support for images, but waiting for 
https://issues.apache.org/jira/browse/PDFBOX-806. 

> Refactor image and jpeg parsers for access to MetadataExtractor API
> -------------------------------------------------------------------
>
>                 Key: TIKA-482
>                 URL: https://issues.apache.org/jira/browse/TIKA-482
>             Project: Tika
>          Issue Type: Improvement
>          Components: parser
>    Affects Versions: 0.7
>            Reporter: Staffan Olsson
>         Attachments: TIKA-451-DublinCore_and_TIKA-482.patch
>
>
> When I added support for more image metadata in TIKA-472, i realized
> the current design had some restrictions:
>  * I could not access the typed getters from Metadata Extractor, such
> as getDate (to format iso date) and getStringArray (for keywords).
>  * The handler function was called one field at a time which prevents
> logic where one field depends on the value of another (there is for
> example record versions and fields that specify encoding)
> See attached patch. It refactors TiffExtractor to MetadataExtractorExtractor.
> The patch also includes the date fix, see 
> https://issues.apache.org/jira/browse/TIKA-451#action_12898794
> We can later add more Extractors using other libraries, and map to parsers 
> based on format. For example we already use ImageIO in ImageParser so maybe 
> there should be an ImageIOExtractor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to