BTW: that said, thanks for taking the time to implement this functionality – it looks great and of course I’m +1 for making it easier for you guys to use Tika in your company!
Cheers, Chris On 11/11/10 6:38 AM, "Maxim Valyanskiy" <[email protected]> wrote: Hello! 11.11.2010 17:05, Jukka Zitting пишет: > Log: >> Extract interface for EmbeddedDocumentExtractor We have POI-based utility that extracts all embedded files (attachments, pictures and etc) from different file formats. This utility takes arbitrary file and returns ZIP-archive with all attachments. This utility duplicates functionality of embedded file processing in Tika. I'm trying to convert my tool from POI to Tika. I think this will make better both my unpacker utility and Tika. I needed a way to replace concrete implementation of EmbeddedDocumentExtractor with my own implementation that copies attachments outside of ContentHandler, so I splitted interface and implementation of that class. > It would be good if all non-trivial commit messages contained a > reference to a relevant issue in Jira for better context of why > particular changes are being made. > > Nick correctly noted earlier that we should write such conventions up > somewhere. I'll try to find time to draft something for review. > So I need to create JIRA issue before commit? best wishes, Max ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris Mattmann, Ph.D. Senior Computer Scientist NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 171-266B, Mailstop: 171-246 Email: [email protected] WWW: http://sunset.usc.edu/~mattmann/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Adjunct Assistant Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
