[ 
https://issues.apache.org/jira/browse/TIKA-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114046#comment-13114046
 ] 

Michael McCandless commented on TIKA-712:
-----------------------------------------

OK I committed four new failing (disabled) test cases, showing that we
don't extract text elements inherited from master/layout slide.

I played around some more with the master layout/slides and I think I
know what we need to do for XSLF (but I have no idea for HSLF;
hopefully it's somehow "parallel"):

  * We'll have to look at the inheritence from slide -> layout ->
    master, so that a slide's text is the union of its actual text,
    plus text from its slide layout, plus text from the master.  The
    files in the _rels dir link a slide to its slideLayout, and a
    slideLayout to its slideMaster.

  * For each text element on slideLayout and slideMaster, we must
    check for the presence of the p:sp -> p:nvSpPr -> p:nvPr -> p:ph
    element.  For example, {{<p:ph type="body" idx="1"/>}}.  The ph
    stands for "place holder", and it seems to mean it's not really
    rendered. When I manually edited the XML in my doc to insert a
    p:ph on text I had added, and viewed that in PowerPoint, it indeed
    stopped rendering it.  So if p:ph is present we should skip that text.

I think that should work!  But I don't know where/how to do this;
likely we need to do this first in POI?  Should I open an issue there?


> Master slide text isn't extracted
> ---------------------------------
>
>                 Key: TIKA-712
>                 URL: https://issues.apache.org/jira/browse/TIKA-712
>             Project: Tika
>          Issue Type: Bug
>          Components: parser
>            Reporter: Michael McCandless
>         Attachments: TIKA-712-master-slide.xml, TIKA-712.patch, 
> testPPT_masterFooter.ppt, testPPT_masterFooter.pptx, 
> testPPT_masterFooter2.ppt, testPPT_masterFooter2.pptx
>
>
> It looks like we are not getting text from the master slide for PPT
> and PPTX.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to