[ 
https://issues.apache.org/jira/browse/TIKA-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176069#comment-13176069
 ] 

Nick Burch commented on TIKA-827:
---------------------------------

I'm not a big fan of the temp file idea, so I've had a try at a different way 
of solving it in r1224863. Instead I have us create our own exception, which is 
serializable, and fill in the stack trace. Possibly we need to recurse into 
child exceptions when doing this, I'm not sure?

We don't currently have a unit test for this, so I'll leave this issue open for 
now while we work out if we have the best route, and while we sort out tests. 
All existing unit tests do pass though
                
> ForkServer fails to report issues if an exception is not properly serializable
> ------------------------------------------------------------------------------
>
>                 Key: TIKA-827
>                 URL: https://issues.apache.org/jira/browse/TIKA-827
>             Project: Tika
>          Issue Type: Bug
>            Reporter: Jerome Lacoste
>         Attachments: 
> 0002-TIKA-827-try-to-report-something-if-the-exception-is.patch
>
>
> {code}
>         try {
>             method.invoke(object, args);
>             output.write(DONE);
>         } catch (InvocationTargetException e) {
>             output.write(ERROR);
>             // warning if an exception isn't really serializable, this can 
> fail.
>             /**
>             File tempFile = File.createTempFile("tika", ".trace");
>             PrintWriter pw = new PrintWriter(tempFile);
>             e.printStackTrace(pw);
>             pw.close();
>             e = new Exception(tempFile.getAbsolutePath());
>             */
>             ForkObjectInputStream.sendObject(e, output);
>         }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to