[
https://issues.apache.org/jira/browse/TIKA-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210237#comment-13210237
]
Jukka Zitting commented on TIKA-865:
------------------------------------
I'd keep the synchronization on "this", as it also covers the add() method call
that
modifies more than just the types map.
More broadly, is there a real measurable performance bottleneck here? If not,
I'd rather optimize for code clarity and simplicity.
> MimeTypes.forName should avoid method-level synchronization
> -----------------------------------------------------------
>
> Key: TIKA-865
> URL: https://issues.apache.org/jira/browse/TIKA-865
> Project: Tika
> Issue Type: Improvement
> Components: mime
> Affects Versions: 1.1
> Reporter: Andrzej Bialecki
>
> MimeTypes.forName can avoid method-level sync, instead it could push down the
> sync block only if a modification of Map<MediaType,MimeType> types is
> required. In most cases this should be enough to free the common case (i.e.
> when a media type is already registered) from synchronization.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
