[ 
https://issues.apache.org/jira/browse/TIKA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531938#comment-13531938
 ] 

Ray Gauss II commented on TIKA-775:
-----------------------------------

According to a few posts on the subject including one on developerWorks [1] it 
looks like it's more appropriate to reassert the thread's interrupt status with:

{code}
...
} catch (InterruptedException ignore) {
    Thread.currentThread().interrupt();
}
...
{code}

rather than refactoring {{ExternalParser}} and {{ExternalEmbedder}} to re-throw 
it or wrap in a {{TikaException}}.


I too would prefer {{ExternalEmbedderTest}} to be in core, but I do feel that 
we want to confirm the embedding with a known working parser.  Would anyone 
have issue with moving {{TXTParser}} and its test into core? There don't seem 
to be any issues with dependencies when trying it.


[1] http://www.ibm.com/developerworks/java/library/j-jtp05236/index.html
                
> Embed Capabilities
> ------------------
>
>                 Key: TIKA-775
>                 URL: https://issues.apache.org/jira/browse/TIKA-775
>             Project: Tika
>          Issue Type: Improvement
>          Components: general, metadata
>    Affects Versions: 1.0
>         Environment: The default ExternalEmbedder requires that sed be 
> installed.
>            Reporter: Ray Gauss II
>              Labels: embed, patch
>             Fix For: 1.3
>
>         Attachments: embed_20121029.diff, embed.diff, 
> tika-core-embed-patch.txt, tika-parsers-embed-patch.txt
>
>
> This patch defines and implements the concept of embedding tika metadata into 
> a file stream, the reverse of extraction.
> In the tika-core project an interface defining an Embedder and a generic sed 
> ExternalEmbedder implementation meant to be extended or configured are added. 
>  These classes are essentially a reverse flow of the existing Parser and 
> ExternalParser classes.
> In the tika-parsers project an ExternalEmbedderTest unit test is added which 
> uses the default ExternalEmbedder (calls sed) to embed a value placed in 
> Metadata.DESCRIPTION then verify the operation by parsing the resulting 
> stream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to