[ 
https://issues.apache.org/jira/browse/TIKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584034#comment-13584034
 ] 

Jukka Zitting commented on TIKA-1074:
-------------------------------------

If we get an InterruptedException, then we shouldn't just log it and continue. 
I'd wrap it to a TikaException and re-throw.

Also instead of:

{code}
} catch (Exception e) {
  ...
  if (e instanceof SomeException) {
      ...
  }
}
{code}

a better pattern might be:

{code}
} catch (SomeException e) {
  ...
} catch (Exception e) {
  ...
}
{code}

                
> Extraction should continue if an exception is hit visiting an embedded 
> document
> -------------------------------------------------------------------------------
>
>                 Key: TIKA-1074
>                 URL: https://issues.apache.org/jira/browse/TIKA-1074
>             Project: Tika
>          Issue Type: Improvement
>          Components: parser
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 1.4
>
>         Attachments: TIKA-1074.patch, TIKA-1074.patch
>
>
> Spinoff from TIKA-1072.
> In that issue, a problematic document (still not sure if document is corrupt, 
> or possible POI bug) caused an exception when visiting the embedded documents.
> If I change Tika to suppress that exception, the rest of the document 
> extracts fine.
> So somehow I think we should be more robust here, and maybe log the 
> exception, or save/record the exception(s) somewhere so after parsing the app 
> could decide what to do about them ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to