[ 
https://issues.apache.org/jira/browse/TIKA-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867228#comment-13867228
 ] 

Nick Burch commented on TIKA-1217:
----------------------------------

Minor thing, but the section "// Then open an InputStream if necessary" would 
probably be more efficient if you used a File not a Stream. TikaInputStream 
will open the stream as needed, but for those things which need a File it'll be 
more efficient if the File is known (else it'll have to spool to a temp file)

> Integrate with Java-7 FileTypeDetector API
> ------------------------------------------
>
>                 Key: TIKA-1217
>                 URL: https://issues.apache.org/jira/browse/TIKA-1217
>             Project: Tika
>          Issue Type: New Feature
>          Components: detector, mime
>            Reporter: Peter Ansell
>         Attachments: TIKA-1217.patch
>
>
> It would be useful if Tika natively provided Java-7 FileTypeDetector [1] 
> implementations. Adding the corresponding 
> META-INF/services/java.nio.file.spi.FileTypeDetector files would allow the 
> use of Files.probeContentType [2] without any specific links to Tika for this 
> functionality.
> If you do not want to rely on Java-7 for the core, then this could be added 
> as an extension module.
> [1] 
> http://docs.oracle.com/javase/7/docs/api/java/nio/file/spi/FileTypeDetector.html
> [2] 
> http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#probeContentType(java.nio.file.Path)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to