[
https://issues.apache.org/jira/browse/TIKA-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015501#comment-14015501
]
Nick Burch commented on TIKA-1311:
----------------------------------
I've had a quick look, and at first glance it looks good
Few minor things:
* A few places look like they need a bit more javadoc completing, eg
JsonMetadataSerializer
* A couple of places look to have odd idents, eg the new pom
* JsonMetadataTest could probably use expanding a little bit more, to cover
some more cases and check more details
* There's some notes about thread safety in comments, should we either address
that, or push the warning up to the javadocs?
Also, we'll need to update the "Getting Started" page to list the serialisation
module in the artifacts section for 1.6, and possibly also make sure it's
up-to-date generally!
> Centralize JSON handling of Metadata
> ------------------------------------
>
> Key: TIKA-1311
> URL: https://issues.apache.org/jira/browse/TIKA-1311
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Minor
> Attachments: TIKA-1311.patch
>
>
> When json was initially added to TIKA CLI (TIKA-213), there was a
> recommendation to centralize JSON handling of Metadata, potentially putting
> it in core. On a recent bug fix (TIKA-1291), the same recommendation was
> repeated especially noting that we now handle JSON/Metadata differently in
> CLI and server.
> Let's centralize JSON handling in core and use GSON. We should add a
> serializer and a deserializer so that users don't have to reinvent that wheel.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
