----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22892/#review46631 -----------------------------------------------------------
trunk/tika-parsers/src/main/java/org/apache/tika/parser/envi/EnviHeaderParser.java <https://reviews.apache.org/r/22892/#comment82136> Good comment Nick. I committed the version of this patch without this improvement, and we can make this improvement later on with a new issue. - Chris Mattmann On June 23, 2014, 11:14 p.m., Ann Burgess wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22892/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 11:14 p.m.) > > > Review request for tika. > > > Bugs: TIKA-1274 > https://issues.apache.org/jira/browse/TIKA-1274 > > > Repository: tika > > > Description > ------- > > New parser for ENVI header files. Note, this is a parser for header files > that will have an associated, separate data file. This parser will not > extract content from the data file. > > > Diffs > ----- > > > trunk/tika-parsers/src/main/java/org/apache/tika/parser/envi/EnviHeaderParser.java > PRE-CREATION > > trunk/tika-parsers/src/test/java/org/apache/tika/parser/envi/EnviHeaderParserTest.java > PRE-CREATION > trunk/tika-parsers/src/test/resources/test-documents/envi_test_header.hdr > PRE-CREATION > > Diff: https://reviews.apache.org/r/22892/diff/ > > > Testing > ------- > > Text parsing test completed with file envi_test_header.hdr. > > > Thanks, > > Ann Burgess > >