----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24052/#review50482 -----------------------------------------------------------
Ship it! Looks good to me. The new unit test looks good and all other tests still pass. There are some unrelated formatting changes. But, nothing major. If someone else reviews and gives another +1, I'll commit it. Tyler - Tyler Palsulich On July 29, 2014, 1:51 p.m., Axel Dörfler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24052/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 1:51 p.m.) > > > Review request for tika. > > > Bugs: TIKA-1063 > https://issues.apache.org/jira/browse/TIKA-1063 > > > Repository: tika > > > Description > ------- > > Note, I have no idea how to add binary files to the diff (if at all > possible). The testStyles.odt is supposed to go into the > "tika-parsers/src/test/resources/test-documents/" directory. > > > Diffs > ----- > > > trunk/tika-parsers/src/main/java/org/apache/tika/parser/odf/OpenDocumentContentParser.java > 1614327 > > trunk/tika-parsers/src/main/java/org/apache/tika/parser/odf/OpenDocumentParser.java > 1614327 > > trunk/tika-parsers/src/test/java/org/apache/tika/parser/odf/ODFParserTest.java > 1614327 > > Diff: https://reviews.apache.org/r/24052/diff/ > > > Testing > ------- > > ODFParserTest.testODTStyles() added. > > > File Attachments > ---------------- > > testStyles.odt > > https://reviews.apache.org/media/uploaded/files/2014/07/29/406503ff-2aef-4609-9955-d3a728402bd5__testStyles.odt > > > Thanks, > > Axel Dörfler > >
