On Tue, 21 Oct 2014, Allison, Timothy B. wrote:
I have Intellij set to order imports by javax, java, then other. I think this is the most common pattern in Tika. Is it ok if I make these (meaningless/formatting) changes when I commit other changes?

The only downside of this is that the top of the commit message is then all "noise", so it's less likely that people will end up skipping the review of the "meat" of the commit

It's not always possible, but where you can, it's generally best to split up "tidy up / formatting" commits (whitespace, imports, formatting etc) ones from ones that touch functionality.

Cheers
Nick

Reply via email to