> On Oct. 31, 2014, 3:22 p.m., Lewis McGibbney wrote: > > File Attachment: GribParser - GribParser.java > > <https://reviews.apache.org/r/27414/#fcomment48> > > > > Is this always available? What happens if we read an InputStream and > > not a File? Can we still populate Metadata.RESOURCE_NAME_KEY? > > Tyler Palsulich wrote: > I think a better solution would be to create a TikaInputStream, then grab > a temporary file from that. See TikaInputStream#get(InputStream, > TemporaryResources) and TikaInputStream#getFile(). Then the Parser won't be > dependent on a Metadata field.
+1 Tyler - Lewis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27414/#review59346 ----------------------------------------------------------- On Nov. 2, 2014, 3:17 p.m., Vineet Ghatge Hemantkumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27414/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2014, 3:17 p.m.) > > > Review request for tika, Lewis McGibbney, Chris Mattmann, and Tyler Palsulich. > > > Bugs: tika-1423 > https://issues.apache.org/jira/browse/tika-1423 > > > Repository: tika > > > Description > ------- > > GRIB Parser Patch > > > Diffs > ----- > > trunk/tika-parsers/pom.xml 1635045 > > Diff: https://reviews.apache.org/r/27414/diff/ > > > Testing > ------- > > To test the parser in place > 1. Download the patch and three file - GribParserTest.java, GribParser.java > and gdas.forecmwf > 2. Put the GribParser.java in the following folder - > tika-parsers/src/main/java/org/apache/tika/parser/grib. You will need to have > folder named grib here > 3. Put the GribParserTest.java in the following folder - > tika-parsers/src/test/java/org/apache/tika/parser/grib > 4. Put the resource file in the following location - > tika-parsers/src/test/resources/test-documents/ > 5. Apply the patch and build. > > > File Attachments > ---------------- > > ParserTestFile > > https://reviews.apache.org/media/uploaded/files/2014/10/31/840fcf4b-d67f-4ed5-8e7c-52d49c74c9d0__GribParserTest.java > GribParser > > https://reviews.apache.org/media/uploaded/files/2014/10/31/2f897768-d61e-4985-a254-4a45fc821524__GribParser.java > Resource file > > https://reviews.apache.org/media/uploaded/files/2014/10/31/a47d7101-98d7-4833-94f3-cdf31351e19e__gdas1.forecmwf.2014062612.grib2 > > > Thanks, > > Vineet Ghatge Hemantkumar > >
