[ 
https://issues.apache.org/jira/browse/TIKA-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated TIKA-1705:
--------------------------------
    Attachment: TIKA-1705-2.patch

Sorry for a second patch. I just noticed that you were using 
"asm-debug-all.jar" instead of plain simple "asm.jar". As this is a very basic 
parser, the asm-commons parts or helper visitors are not needed, so we should 
fallback to plain asm (also for compatibility with other projects). The -debug 
stuff was previously used because of generics warnings in earlier versions 
(they stripped off generics from JAR file), but this is no longer an issue.

So please apply this patch, too :-)

> Update ASM dependency to 5.0.4
> ------------------------------
>
>                 Key: TIKA-1705
>                 URL: https://issues.apache.org/jira/browse/TIKA-1705
>             Project: Tika
>          Issue Type: Task
>    Affects Versions: 1.7
>            Reporter: Uwe Schindler
>            Assignee: Dave Meikle
>             Fix For: 1.11
>
>         Attachments: TIKA-1705-2.patch, TIKA-1705.patch
>
>
> Currently the Class file parser uses ASM 4.1. This older version cannot read 
> Java 8 / Java 9 class files (fails with Exception).
> The upgrade to ASM 5.0.4 is very simple, just Maven dependency change. The 
> code change is only to update the visitor version, so it gets new Java 8 
> features like lambdas reported, but this is not really required, but should 
> be done for full support.
> FYI, in LUCENE-6729 we want to upgrade the Lucene Expressions module to ASM 
> 5, too.
> You can hot-swap ASM 4.1 with ASM 5.0.4 without recompilation (so we have no 
> problem with Lucene using a newer version). Since ASM 4.x the updates are 
> more easy (no visitor interfaces anymore, instead abstract classes), so it 
> does not break if you just replace the JAR file. So just see this as a 
> recommendatation, not urgent! Solr/Lucene will also work without this patch 
> (it just replaces the shipped ASM by newer version in our packaging).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to