[ 
https://issues.apache.org/jira/browse/TIKA-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167123#comment-15167123
 ] 

Nick Burch commented on TIKA-1855:
----------------------------------

Currently, we have most test documents in Tika Parsers, and a handful in Tika 
Core, which is sometimes confusing. We also end up with quite a lot of the unit 
tests for Tika Core actually being in the Tika Parsers test area, so that they 
can use the test documents in parsers which aren't in core. Based on my 
experiences with this (eg where I start putting things in the wrong module, 
initially can't find the right unit test etc), I find it non-ideal, and I 
suspect it's not intuitive at all for new contributors.

For the Ogg Vorbis stuff I maintain, I've opted to put all of the test files 
needed in {{core/src/test/resources}} then have the other maven modules (eg the 
Tika one and the Tools one) depend on the core-test artifact as a test-scope 
dependency in order for their unit tests to access the common set of test 
files. I find this actually works quite well, now I have it set up, and it 
seems ok for both InputStream and File based tests

So, given the above two, I would suggest that we put all of our test documents 
from core, parsers, server and bundle (all of which seem to have their own ones 
at the moment!) into a single artifact. We then depend on that artifact for all 
of our tests, with a test scope

> TIka 2.0 - Move shared test-code back to tika-core and distribute test files 
> to parser modules
> ----------------------------------------------------------------------------------------------
>
>                 Key: TIKA-1855
>                 URL: https://issues.apache.org/jira/browse/TIKA-1855
>             Project: Tika
>          Issue Type: Sub-task
>            Reporter: Tim Allison
>            Assignee: Tim Allison
>
> Undo TIKA-1851, and divide test docs to appropriate parser modules.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to