[ 
https://issues.apache.org/jira/browse/TIKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182860#comment-15182860
 ] 

Nick Burch commented on TIKA-1888:
----------------------------------

Our current mimetype definition for netcdf is:
{code}
  <mime-type type="application/x-netcdf">
    <glob pattern="*.nc"/>
    <glob pattern="*.cdf"/>
    <magic priority="50">
      <match value="CDF\001" type="string" offset="0" />
      <match value="CDF\002" type="string" offset="0" />
    </magic>
  </mime-type>
{code}

Your change seems to remove one possible magic match, and make the magic less 
easy to read... Am I missing something?

> Update mimetype for application/x-netcdf
> ----------------------------------------
>
>                 Key: TIKA-1888
>                 URL: https://issues.apache.org/jira/browse/TIKA-1888
>             Project: Tika
>          Issue Type: Improvement
>          Components: core, mime
>    Affects Versions: 1.13
>            Reporter: Ajay Kumar Loganathan Ravichandran
>              Labels: mimetypes
>             Fix For: 1.13
>
>
> Updating tika-mimetype.xml to identify .cdf and .nc file format.
> <mime-type type="application/x-netcdf">
>       <glob pattern="*.nc"/>
>       <glob pattern="*.cdf"/>
>      <magic priority="50">
>        <match value="0x43444601" type="string" offset="0"/>
>     </magic>
>     </mime-type>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to