[
https://issues.apache.org/jira/browse/TIKA-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304041#comment-15304041
]
Tim Allison commented on TIKA-1986:
-----------------------------------
Wow. This will be so cool. I made one trivial recommendation on Github.
The following is picky, but this is a major new addition to the API, and I
think your superb work deserves a critical review. :)
Would it be possible to add serialization of the parameters to
TikaConfigSerializer? I may have missed this. Not crucial for the initial
patch, but we'll want to add this.
Going forward (Tika 2.0), how do we want the parsers to interact with the
configuration? Should they interact directly with the params, or should they
initialize their current param variables with the params?
What's the benefit of configuring with a ParseContext instead of a Map<String,
Param<?>>? Along the same lines, {{configure}} doesn't actually configure, it
just sets the Map... Should we rename it as a setter? Or should we make it do
something?
IIRC AbstractParser is only there as syntactic sugar to gloss over the newer
requirement to pass in a ParseContext at parse time. In 2.0, AbstractParser
will go away...I think. So, might be better to make ConfigurableParser an
abstract class that handles all of the functionality instead of an interface.
Not crucial for the initial patch, but it would be great if we could add error
checking/automatic configuration (perhaps via reflection) at the level of the
ConfigurableParser so that each parser (configurable?) doesn't have to set
their own params.
> support parser parameters with type (int, double, etc) in configuration XML
> file
> --------------------------------------------------------------------------------
>
> Key: TIKA-1986
> URL: https://issues.apache.org/jira/browse/TIKA-1986
> Project: Tika
> Issue Type: Sub-task
> Components: config
> Reporter: Thamme Gowda
> Fix For: 1.14
>
>
> Tika Configuration should be enhanced to support for basic types like int,
> double, boolean, url, file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
