Hey Tim, Just started taking a look. The test-jar approach could work but I recall I ran into some issues with getting access to some of the test files inside the test-jars for some of the junits. For many tests this was simple but for some I think it would require larger functional changes to the code that I was not comfortable proposing at the time.
Makes sense to try this path again and see if you can get further than I did. - Bob On 8/18/2020 9:40 AM, Tim Allison wrote: > If anyone has any time, please take a look here: > https://github.com/apache/tika/tree/branch_2x/tika-parser-modules > > Does this basically look ok? > > I've put the integration tests in > https://github.com/apache/tika/tree/branch_2x/tika-parser-integration-tests > ... that doesn't build yet. > > I've flipped Bob's design so that the integration tests pull test files > from the individual parser modules via test-jar. > > On Fri, Aug 14, 2020 at 3:30 PM Bob Paulin <b...@bobpaulin.com> wrote: > >> +1 excited about this. >> >> - Bob >> On 8/14/2020 11:29 AM, Sergey Beryozkin wrote: >> >> +1 😀 >> >> Cheers Sergey >> >> On Fri 14 Aug 2020, 18:26 Chris Mattmann, <mattm...@apache.org> >> <mattm...@apache.org> wrote: >> >> >> Haha I’m down and supportive! >> >> >> >> Time’s TIME FOR 2.x 😊 >> >> >> >> >> >> >> >> From: Tim Allison <talli...@apache.org> <talli...@apache.org> >> Reply-To: "dev@tika.apache.org" <dev@tika.apache.org> <dev@tika.apache.org> >> <dev@tika.apache.org>, "Allison, Tim (US >> 174B-Affiliate)" <timothy.b.alli...@jpl.nasa.gov> >> <timothy.b.alli...@jpl.nasa.gov> >> Date: Friday, August 14, 2020 at 6:06 AM >> To: "<dev@tika.apache.org> <dev@tika.apache.org>" <dev@tika.apache.org> >> <dev@tika.apache.org> >> Subject: [EXTERNAL] Tika 2.0 modularization >> >> >> >> All, >> >> I _think_ I might have some time to start working on integrating Bob's >> >> work on the current main branch. I'll have to ignore most of the incoming >> >> issues for a bit...unlike the last 4 years...this time I mean it. :) >> >> Let me know if there are any objections to heading down this path now. >> >> >> >> Cheers, >> >> >> >> Tim >> >> >> >> >> >>
signature.asc
Description: OpenPGP digital signature
