kkrugler commented on a change in pull request #379:
URL: https://github.com/apache/tika/pull/379#discussion_r525579096
##########
File path: tika-core/src/test/java/org/apache/tika/config/ParamTest.java
##########
@@ -61,8 +61,6 @@ public void testSaveAndLoad() throws Exception {
ByteArrayOutputStream stream = new ByteArrayOutputStream();
param.save(stream);
ByteArrayInputStream inStream = new
ByteArrayInputStream(stream.toByteArray());
- stream.close();
- inStream.close();
Review comment:
Findbugs would (or at least used to) always report a missing close on
any kind of InputStream (anything that was closable). And yes, I was suggesting
putting those two calls at the end of the loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
