On Thu, 19 Nov 2020, Nick Burch wrote:
On Thu, 19 Nov 2020, Tim Allison wrote:
Looks like 'scale' needs to be taken into consideration? See 1.2.6.9

https://www.adobe.com/content/dam/acom/en/devnet/xmp/pdfs/XMPSDKReleasecc-2020/XMPSpecificationPart2.pdf

Ah, yes, check the spec!

1.2.6.5 suggests that xmpDM:duration can be frames or can be in seconds, when used for a marker. 1.2.6.6 seems to say the overall media xmpDM:duration should be a time with a default unit in seconds (unless changed by a scale)

I guess we could set a scale for mp3 and leave the duration in ms, but swapping it to seconds seems cleaner/better to me, even though it's a breaking change.

I'm thinking I'll fix this on both 1.x and 2 in a few days. 2.x feels a no-brainer, 1.x is a breaking change but arguably has been a long-standing bug that no-one has flagged until now.

Any objections, before I raise a JIRA and commit the fixes?

Thanks
Nick

Reply via email to