[
https://issues.apache.org/jira/browse/TIKA-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342236#comment-17342236
]
ASF GitHub Bot commented on TIKA-3390:
--------------------------------------
kamaci commented on a change in pull request #437:
URL: https://github.com/apache/tika/pull/437#discussion_r629789195
##########
File path:
tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/onenote/ExtendedGUID.java
##########
@@ -35,7 +35,7 @@ public static ExtendedGUID nil() {
@Override
public int compareTo(ExtendedGUID other) {
if (other.guid.equals(guid)) {
- new Long(n).compareTo(other.n);
+ return Long.compare(n, other.n);
Review comment:
I've changed it like that since it seems like a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Migrate Language Level to Java 8
> --------------------------------
>
> Key: TIKA-3390
> URL: https://issues.apache.org/jira/browse/TIKA-3390
> Project: Tika
> Issue Type: Improvement
> Affects Versions: 1.26
> Reporter: Furkan Kamaci
> Priority: Minor
> Fix For: 1.27
>
>
> Apache Tika supports JDK 8. However, source code does not use the power of
> new syntax and improvements since Java 5. This issue aims to migrate the most
> recent supported JDK level to have better readability and performant code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
