[
https://issues.apache.org/jira/browse/TIKA-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537608#comment-17537608
]
ASF GitHub Bot commented on TIKA-1735:
--------------------------------------
monkmachine commented on code in PR #558:
URL: https://github.com/apache/tika/pull/558#discussion_r873872474
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-cad-module/src/main/java/org/apache/tika/parser/dwg/AbstractDWGParser.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tika.parser.dwg;
+
+
+import org.apache.tika.config.Field;
+import org.apache.tika.parser.AbstractParser;
+import org.apache.tika.parser.ParseContext;
+
+
+
+
+public abstract class AbstractDWGParser extends AbstractParser {
+
+
+ /**
+ *
+ */
+ private static final long serialVersionUID = 6261810259683381984L;
+ private final DWGParserConfig defaultDwgParserConfig = new
DWGParserConfig();
+
+ public void configure(ParseContext parseContext) {
+ DWGParserConfig dwgParserConfig =
parseContext.get(DWGParserConfig.class, defaultDwgParserConfig);
+ parseContext.set(DWGParserConfig.class, dwgParserConfig);
+ }
+
+
+ String getDwgReadExecutable() {
+ return defaultDwgParserConfig.getDwgReadExecutable();
+ }
+
+ @Field
+ public void setDwgReadExecutable(String dwgReadExecutable) {
+ defaultDwgParserConfig.setDwgReadExecutable(dwgReadExecutable);
+ }
+
+ boolean isCleanDwgReadOutput() {
+ return defaultDwgParserConfig.isCleanDwgReadOutput();
+ }
+
+ @Field
+ public void setCleanDwgReadOutput(boolean cleanDwgReadOutput) {
+ defaultDwgParserConfig.setCleanDwgReadOutput(cleanDwgReadOutput);
+ }
+
+ int getCleanDwgReadOutputBatchSize() {
+ return defaultDwgParserConfig.getCleanDwgReadOutputBatchSize();
+ }
+
+ @Field
+ public void setCleanDwgReadOutputBatchSize(int
cleanDwgReadOutputBatchSize) {
+
defaultDwgParserConfig.setCleanDwgReadOutputBatchSize(cleanDwgReadOutputBatchSize);
+ }
+ String getCleanDwgReadRegexToReplace() {
+ return defaultDwgParserConfig.getCleanDwgReadRegexToReplace();
+ }
+
+ @Field
+ public void setCleanDwgReadRegexToReplace(String
cleanDwgReadRegexToReplace) {
+
defaultDwgParserConfig.setCleanDwgReadRegexToReplace(cleanDwgReadRegexToReplace);
+ }
+ String getCleanDwgReadReplaceWith() {
+ return defaultDwgParserConfig.getCleanDwgReadReplaceWith();
+ }
+
+ @Field
+ public void setCleanDwgReadReplaceWith(String cleanDwgReadReplaceWith) {
+
defaultDwgParserConfig.setCleanDwgReadReplaceWith(cleanDwgReadReplaceWith);
+ }
+
Review Comment:
>
Hi @tballison
It seems to work ok, I've compiled a version of tika server and if I don't
supply the parser config it falls back to the old parser. If the config is
incorrect then Tika server fails to start (which is what we want?)
Parser config looks like this:
```
<parser class="org.apache.tika.parser.dwg.DWGReadParser">
<params>
<param name="dwgReadExecutable"
type="string">G:/libredwg-0.12.5-win64/dwgread.exe</param>
<param name="cleanDwgReadOutput" type="bool">true</param>
<param name="cleanDwgReadOutputBatchSize"
type="int">10000000</param>
<param name="dwgReadTimeout" type="long">10</param>
<param name="cleanDwgReadRegexToReplace"
type="string">[^\x20-\x7e]| nan,| nan </param>
<param name="cleanDwgReadReplaceWith" type="string"/>
</params>
</parser>
> Unsupported AutoCAD drawing version: AC1027
> -------------------------------------------
>
> Key: TIKA-1735
> URL: https://issues.apache.org/jira/browse/TIKA-1735
> Project: Tika
> Issue Type: Bug
> Reporter: Luca Perico
> Priority: Major
> Attachments: testDWG-AC1027.dwg
>
>
> Trying to index .dwg file (version AC1027) I get 500 error response.
> "<?xml version=""1.0"" encoding=""UTF-8""?>
> <response>
> <lst name=""responseHeader""><int name=""status"">500</int><int
> name=""QTime"">3</int></lst><lst name=""error""><str A1:F378 Unsupported
> AutoCAD drawing version: AC1027</str><str
> name=""trace"">org.apache.solr.common.SolrException:
> org.apache.tika.exception.TikaException: Unsupported AutoCAD drawing version:
> AC1027
> at
> org.apache.solr.handler.extraction.ExtractingDocumentLoader.load(ExtractingDocumentLoader.java:227)
> at
> org.apache.solr.handler.ContentStreamHandlerBase.handleRequestBody(ContentStreamHandlerBase.java:74)
> at
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143)
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:2064)
> at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:654)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:450)
> at
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:227)
> at
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:196)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:110)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
> at org.eclipse.jetty.server.Server.handle(Server.java:497)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
> at
> org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: org.apache.tika.exception.TikaException: Unsupported AutoCAD
> drawing version: AC1027
> at org.apache.tika.parser.dwg.DWGParser.parse(DWGParser.java:131)
> at
> org.apache.tika.parser.CompositeParser.parse(CompositeParser.java:256)
> at
> org.apache.tika.parser.CompositeParser.parse(CompositeParser.java:256)
> at
> org.apache.tika.parser.AutoDetectParser.parse(AutoDetectParser.java:120)
> at
> org.apache.solr.handler.extraction.ExtractingDocumentLoader.load(ExtractingDocumentLoader.java:221)
> ... 27 more
> </str><int name=""code"">500</int></lst>
> </response>"
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
