[ https://issues.apache.org/jira/browse/TIKA-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770173#comment-17770173 ]
ASF GitHub Bot commented on TIKA-4145: -------------------------------------- tballison opened a new pull request, #1370: URL: https://github.com/apache/tika/pull/1370 <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> Thanks for your contribution to [Apache Tika](https://tika.apache.org/)! Your help is appreciated! Before opening the pull request, please verify that * there is an open issue on the [Tika issue tracker](https://issues.apache.org/jira/projects/TIKA) which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes. * the issue ID (`TIKA-XXXX`) - is referenced in the title of the pull request - and placed in front of your commit messages surrounded by square brackets (`[TIKA-XXXX] Issue or pull request title`) * commits are squashed into a single one (or few commits for larger changes) * Tika is successfully built and unit tests pass by running `mvn clean test` * there should be no conflicts when merging the pull request branch into the *recent* `main` branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled `main` branch * if you add new module that downstream users will depend upon add it to relevant group in `tika-bom/pom.xml`. We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the [Tika mailing list](http://tika.apache.org/mail-lists.html). Thanks! > Consider reverting CloseShieldInputStream.wrap() for back compat > ---------------------------------------------------------------- > > Key: TIKA-4145 > URL: https://issues.apache.org/jira/browse/TIKA-4145 > Project: Tika > Issue Type: Task > Reporter: Tim Allison > Priority: Minor > > Over on Nutch, we found that hadoop in distributed mode enforces its > dependencies getting loaded first. Unfortunately, hadoop 3.3.x is using a > version of commons-io that does not include CloseShieldInputStream.wrap(). > This issue should be fixed in hadoop 3.4.x, but we have no idea how far off > that release is. > From commons-io's documentation, there's no performance benefit from > wrap()... it only helps when debugging in an IDE. > See: NUTCH-3006 and its links > Maybe do this in the 2.x branch and run a release of 2.9.1 with updated > dependencies soon? > WDYT? -- This message was sent by Atlassian Jira (v8.20.10#820010)