[
https://issues.apache.org/jira/browse/TIKA-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810095#comment-17810095
]
ASF GitHub Bot commented on TIKA-4119:
--------------------------------------
tballison commented on code in PR #1556:
URL: https://github.com/apache/tika/pull/1556#discussion_r1463954328
##########
tika-core/src/test/java/org/apache/tika/mime/ProbabilisticMimeDetectionTest.java:
##########
@@ -135,7 +136,7 @@ private void testFile(String expected, String filename)
throws IOException {
private void testStream(String expected, String urlOrFileName, InputStream
in)
throws IOException {
- assertNotNull("Test stream: [" + urlOrFileName + "] is null!", in);
+ assertNotNull(in, "Test stream: [" + urlOrFileName + "] is null!");
Review Comment:
Ha, right, the tests pass because our current test is "is the warning
message not null", and in fact, the warning message is not null. LOL...
> Return media type "text/javascript" instead of "application/javascript to
> follow RFC-9239
> -----------------------------------------------------------------------------------------
>
> Key: TIKA-4119
> URL: https://issues.apache.org/jira/browse/TIKA-4119
> Project: Tika
> Issue Type: Improvement
> Components: mime
> Reporter: Matthias Juchmes
> Priority: Major
> Labels: tika-3x
>
> [RFC-9239|https://www.rfc-editor.org/rfc/rfc9239.html] obsoletes some
> javascript media types, including "application/javascript", which is
> currently returned by Tika for javascript files. "text/javascript" is defined
> as the most widely supported one, so Tika should reflect this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
