[
https://issues.apache.org/jira/browse/TIKA-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859757#comment-17859757
]
Nicholas DiPiazza edited comment on TIKA-4251 at 6/24/24 6:35 PM:
------------------------------------------------------------------
we could keep everything how it is but:
* provide instructions how to run the code formatter on the entire repo with
google checkstyle.
* run it on the entire codebase and commit the now-fully-formatted repo
* advise everyone turn on the automatic code formatting in Intellij/Eclipse so
that you automatically have your code formatted.
Now that plugin doesn't control us so much, but we still have easy way to stay
fully formatted so we stop getting the back-and-forth with maven and CI when we
forget to format something.
was (Author: ndipiazza):
we could keep everything how it is but:
* provide instructions how to run the code formatter manually
* run it on the entire codebase and commit the now-fully-formatted repo
* advise everyone turn on the automatic code formatting in Intellij/Eclipse so
that you automatically have your code formatted.
Now that plugin doesn't control us so much, but we still have easy way to stay
fully formatted so we stop getting the back-and-forth with maven and CI when we
forget to format something.
> [DISCUSS] move to cosium's git-code-format-maven-plugin with
> google-java-format
> -------------------------------------------------------------------------------
>
> Key: TIKA-4251
> URL: https://issues.apache.org/jira/browse/TIKA-4251
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Major
>
> I was recently working a bit on incubator-stormcrawler, and I noticed that
> they are using cosium's git-code-format-maven-plugin:
> https://github.com/Cosium/git-code-format-maven-plugin
> I was initially annoyed that I couldn't quickly figure out what I had to fix
> to make the linter happyl, but then I realized there was a magic command:
> {{mvn git-code-format:format-code}} which just fixed the code so that the
> linter passed.
> The one drawback I found is that it does not fix nor does it alert on
> wildcard imports. We could still use checkstyle for that but only have one
> rule for checkstyle.
> The other drawback is that there is not a lot of room for variation from
> google's style. This may actually be a benefit, too, of course.
> I just ran this on {{tika-core}} here:
> https://github.com/apache/tika/tree/google-java-format
> What would you think about making this change for 3.x?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
