[ https://issues.apache.org/jira/browse/TIKA-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866165#comment-17866165 ]
Hudson commented on TIKA-4278: ------------------------------ SUCCESS: Integrated in Jenkins build Tika ยป tika-main-jdk11 #1686 (See [https://ci-builds.apache.org/job/Tika/job/tika-main-jdk11/1686/]) TIKA-4278: no confidence if the delimiter isn't in row zero (tilman: [https://github.com/apache/tika/commit/cdfa5ad02bae8bedb9e6646d6aed0a3c50369d3e]) * (edit) tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-text-module/src/main/java/org/apache/tika/parser/csv/CSVSniffer.java > TextAndCSVParser doesn't detect semicolon separated file > -------------------------------------------------------- > > Key: TIKA-4278 > URL: https://issues.apache.org/jira/browse/TIKA-4278 > Project: Tika > Issue Type: Bug > Components: parser > Affects Versions: 2.9.2 > Reporter: Tilman Hausherr > Assignee: Tilman Hausherr > Priority: Major > Labels: csv, csvparser > Fix For: 3.0.0, 2.9.3 > > Attachments: reports_csv_2.9.2_vs_2.9.3.tar.xz, > reports_csv_2.9.2_vs_2.9.3_3.tar.xz > > > I ran the code from the attached SO issue and yes it doesn't detect semicolon > separated files. The reason is this line in {{TextAndCSVParser.java}}: > {code:java} > private static final char[] DEFAULT_DELIMITERS = new char[]\{',', '\t'}; > {code} > This is later used by {{CSVSniffer}}. For some reason the other delimiters > (pipe, colon and semicolon) aren't in that array, although they are in > {{CHAR_TO_STRING_DELIMITER_MAP}}. I modified {{DEFAULT_DELIMITERS}} and now > it works for semicolon. > Can I change this by adding the missing delimiters or was there a reason that > I missed? Proposed change would change CSVSniffer so that delimiters is a set > and then pass {{CHAR_TO_STRING_DELIMITER_MAP.keySet()}}. -- This message was sent by Atlassian Jira (v8.20.10#820010)