[
https://issues.apache.org/jira/browse/TIKA-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18028550#comment-18028550
]
ASF GitHub Bot commented on TIKA-4510:
--------------------------------------
LucaDai commented on PR #2360:
URL: https://github.com/apache/tika/pull/2360#issuecomment-3384503422
> Thanks, this is much better. More to do: 1) Create an issue in JIRA 2)
rename the title of this PR to
"[TIKA-XXXX](https://issues.apache.org/jira/browse/TIKA-XXXX): your text......"
(replace XXXX with the number you got in step 1), 3) add a 1 line comment in
the code with a text like
"[TIKA-XXXX](https://issues.apache.org/jira/browse/TIKA-XXXX) @put and @post
separately to avoid nondeterministic failures" (this is to avoid that in a few
years someone refactors the code to make it shorter) 4) if you know how to do
it, squash your commits and change the commit text so that it begins with
[TIKA-XXXX](https://issues.apache.org/jira/browse/TIKA-XXXX) .
Thanks a lot for the clear guidance!
I’ve followed all the steps (JIRA issue, PR title, inline comment, and
squashed commit).
Could you please review it again?
> Nondeterministic failures in LanguageResourceTest
> -------------------------------------------------
>
> Key: TIKA-4510
> URL: https://issues.apache.org/jira/browse/TIKA-4510
> Project: Tika
> Issue Type: Bug
> Components: tika-server
> Affects Versions: 3.2.3
> Reporter: Tiancheng Dai
> Priority: Minor
> Labels: test-stability
> Fix For: 4.0.0, 3.3.0
>
>
> *Summary:*
> {{LanguageResourceTest}} shows nondeterministic failures when run with
> NonDex(shuffling nondeterministic method to find flakiness).
> ----
> *Observation / How to Reproduce:*
> Running the following command may intermittently fail with errors:
>
> {{mvn -pl tika-server/tika-server-core \
> edu.illinois:nondex-maven-plugin:2.2.1:nondex \
> -Dtest=org.apache.tika.server.core.LanguageResourceTest \
> -DnondexRuns=5}}
> *Observed behavior:*
> [INFO] Running org.apache.tika.server.core.LanguageResourceTest
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.638
> s <<< FAILURE! -- in org.apache.tika.server.core.LanguageResourceTest
> [ERROR]
> org.apache.tika.server.core.LanguageResourceTest.testDetectEnglishFile --
> Time elapsed: 0.629 s <<< FAILURE!org.opentest4j.AssertionFailedError:
> expected: <en> but was: <> at
> org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:158)
> at
> org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:139)
> at
> org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:201)
> at
> org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:184)
> at
> org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:179)
> at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1188)
> at
> org.apache.tika.server.core.LanguageResourceTest.testDetectEnglishFile(LanguageResourceTest.java:98)
> *Expected behavior:*
> *The test should deterministically pass under all NonDex seeds.*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
