[ 
https://issues.apache.org/jira/browse/TIKA-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18044467#comment-18044467
 ] 

Hudson commented on TIKA-4564:
------------------------------

SUCCESS: Integrated in Jenkins build Tika » tika-main-jdk17 #1098 (See 
[https://ci-builds.apache.org/job/Tika/job/tika-main-jdk17/1098/])
TIKA-4564 -- replace string.replace with actual json interpolation in unit 
tests (#2439) (github: 
[https://github.com/apache/tika/commit/c29b4810b1011e734200bf84dcc65bca5bc9d44e])
* (add) 
tika-serialization/src/main/java/org/apache/tika/config/JsonConfigHelper.java
* (edit) 
tika-integration-tests/tika-pipes-opensearch-integration-tests/src/test/java/org/apache/tika/pipes/opensearch/tests/OpenSearchTest.java
* (edit) 
tika-pipes/tika-pipes-integration-tests/src/test/resources/configs/tika-config-passback.json
* (edit) 
tika-integration-tests/tika-pipes-kafka-integration-tests/src/test/java/org/apache/tika/pipes/kafka/tests/TikaPipesKafkaTest.java
* (edit) 
tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolrTestBase.java
* (edit) 
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/TikaResourceFetcherTest.java
* (edit) tika-app/src/test/java/org/apache/tika/cli/TikaCLIAsyncTest.java
* (edit) 
tika-integration-tests/tika-pipes-s3-integration-tests/src/test/resources/s3/plugins-template.json
* (edit) 
tika-integration-tests/tika-pipes-s3-integration-tests/src/test/java/org/apache/tika/pipes/s3/tests/S3PipeIntegrationTest.java
* (edit) 
tika-pipes/tika-async-cli/src/test/java/org/apache/tika/async/cli/AsyncProcessorTest.java
* (edit) 
tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/emitter/EmitterManagerTest.java
* (add) 
tika-serialization/src/test/java/org/apache/tika/config/JsonConfigHelperTest.java
* (edit) 
tika-integration-tests/tika-pipes-opensearch-integration-tests/src/test/resources/opensearch/plugins-template.json
* (edit) 
tika-integration-tests/tika-pipes-solr-integration-tests/src/test/resources/solr/plugins-template.json
* (edit) 
tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java
* (edit) 
tika-server/tika-server-core/src/test/resources/configs/cxf-test-base-template.json
* (add) tika-serialization/src/test/resources/configs/template-test.json
* (edit) 
tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/PluginsTestHelper.java
* (edit) 
tika-server/tika-server-standard/src/test/resources/configs/cxf-test-base-template.json
* (edit) 
tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/fetcher/FetcherManagerTest.java
* (edit) 
tika-pipes/tika-pipes-integration-tests/src/test/resources/configs/tika-config-basic.json
* (edit) 
tika-server/tika-server-core/src/test/resources/configs/tika-config-server-fetcher-template.json


> Add helper class to avoid string.replace in json-templated unit tests
> ---------------------------------------------------------------------
>
>                 Key: TIKA-4564
>                 URL: https://issues.apache.org/jira/browse/TIKA-4564
>             Project: Tika
>          Issue Type: Task
>            Reporter: Tim Allison
>            Priority: Major
>             Fix For: 4.0.0
>
>
> We keep having problems with \ on Windows in tests that use json 
> configuration. We should create a centralized helper class that will do the 
> interpolation on actual json objects and uniformly convert \ to / as default. 
> We'll need to allow some cases of \ obviously...
>  
> Details to be determined... Sound reasonable?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to