Copilot commented on code in PR #2735:
URL: https://github.com/apache/tika/pull/2735#discussion_r3037161116
##########
tika-server/tika-server-standard/src/test/java/org/apache/tika/server/standard/UnpackerResourceWithConfigTest.java:
##########
@@ -260,4 +262,12 @@ public void testPDFPerPageRenderGray() throws Exception {
assertTrue(averageColor.getBlue() < 100 && averageColor.getBlue()
> 90);
}
}
+
+ @AfterAll
+ public void tearDown() throws Exception {
+ super.tearDown();
+ if (unpackTempDir != null && Files.exists(unpackTempDir)) {
+ FileUtils.deleteQuietly(unpackTempDir.toFile());
Review Comment:
`FileUtils.deleteQuietly(...)` will silently ignore failures, which can
leave the temp unpack directory behind with no signal (potentially defeating
the purpose of TIKA-4704). Consider using `FileUtils.deleteDirectory(...)` (or
catching/logging any IOException) so cleanup failures are visible and
consistent with other tests in this module (e.g., `TikaPipesTest`). Also,
adding `@Override` here would make it explicit that this method overrides
`CXFTestBase#tearDown`.
```suggestion
@Override
public void tearDown() throws Exception {
super.tearDown();
if (unpackTempDir != null && Files.exists(unpackTempDir)) {
FileUtils.deleteDirectory(unpackTempDir.toFile());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
