[
https://issues.apache.org/jira/browse/TIKA-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099855#comment-18099855
]
ASF GitHub Bot commented on TIKA-4796:
--------------------------------------
tballison commented on PR #2972:
URL: https://github.com/apache/tika/pull/2972#issuecomment-5109900007
Thank you @gsingers !
> Caching of MagicDetector pattern compilations
> ---------------------------------------------
>
> Key: TIKA-4796
> URL: https://issues.apache.org/jira/browse/TIKA-4796
> Project: Tika
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Minor
>
> I've been doing some profiling of Tika as part of a broader focus on a
> document extraction pipeline and one of the areas that shows up more than
> expected and appears to be an easy fix is the
> {code:java}
> Pattern p = Pattern.compile(new String(this.pattern, UTF_8), flags);{code}
> line in `matchesBuffer` (trunk/main) and the `detect` method in the 3.x line.
>
> The fix is to compile the pattern in the initialization. Patch/fix coming
> shortly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
