dschmidt opened a new pull request, #2983: URL: https://github.com/apache/tika/pull/2983
Fixes TIKA-4801 for the three formats where the pictures are reachable today: ID3v2 APIC frames (v2.2 PIC included), the MP4/M4A `covr` atom (previously explicitly skipped) and Vorbis/Opus `metadata_block_picture` comments. Each picture is emitted through the standard EmbeddedDocumentExtractor mechanism as an inline embedded document, the same way PDF and Office parsers emit embedded images: /rmeta returns one metadata entry per cover with the declared content type (or auto-detection where MP4 only has a type code), the declared description as dc:title and the picture type as dc:description; /unpack delivers the bytes. Deliberately no new metadata properties on the audio document and no mapping of the width/height fields that Vorbis picture blocks declare: ID3 and MP4 declare no dimensions at all, and the embedded entry carries the real ones once image parsers are on the classpath. The raw metadata_block_picture comment is no longer passed through as a giant base64 vorbis: value, it becomes the embedded document instead. FLAC native PICTURE blocks are out of scope for now: vorbis-java 0.8 keeps the metadata blocks in a field without a public accessor, so that needs a small upstream addition first. One commit per format, each with its own fixture and end-to-end test; the fixtures are minimally modified copies of existing test files carrying a 1x1 PNG cover (for the Ogg fixture the comment packet was rewritten with recomputed page CRC). All three tests fail without their parser change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
