THausherr commented on PR #3114:
URL: https://github.com/apache/tika/pull/3114#issuecomment-5558159129
I partly agree with copilot, because you also have this:
```
byte[] header = boxes.read(position, 16);
if (header == null || header.length < 8) {
return null;
}
```
so you can handle less than 8 bytes. `boxes.read()` should check the length.
I disagree with copilot that it returns null whenever fewer than 8 bytes
remain, because it would work if less than 8 bytes would be requested. Anyway,
it feels kindof weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
