timgrein commented on code in PR #3142:
URL: https://github.com/apache/tika/pull/3142#discussion_r3955752609
##########
tika-core/src/main/java/org/apache/tika/io/FilenameUtils.java:
##########
@@ -400,7 +400,7 @@ public static String calculateExtension(Metadata metadata,
String defaultValue)
if (ext != null) {
return ext;
}
- return ".bin";
+ return defaultValue;
Review Comment:
This could be `null` though. Not sure how that should be handled? We could
add `@NotNull` to `defaultValue`, iff that should be the contract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
