Copilot commented on code in PR #3149:
URL: https://github.com/apache/tika/pull/3149#discussion_r3970534686
##########
tika-core/src/main/java/org/apache/tika/utils/ProcessUtils.java:
##########
@@ -442,4 +449,16 @@ public static boolean waitForWithHeartbeat(Process p,
ParseContext context, long
}
}
+ private static Optional<FileProcessResult> failFastIfNoGrantedTimeout(long
requestedTimeoutMillis, long grantedTimeoutMillis) {
+ if (grantedTimeoutMillis <= 0) {
+ FileProcessResult result = new FileProcessResult();
+ result.isTimeout = true;
+ result.requestedTimeoutMillis = requestedTimeoutMillis;
+ result.grantedTimeoutMillis = grantedTimeoutMillis;
+
+ return Optional.of(result);
+ }
+
+ return Optional.empty();
+ }
Review Comment:
The new Javadoc includes `@param` tags without descriptions. Some builds
enforce Javadoc completeness (e.g., via Checkstyle), and even when not enforced
it reduces clarity. Add brief descriptions for both parameters (or remove the
tags if not needed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
