[
https://issues.apache.org/jira/browse/TIKA-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113516#comment-18113516
]
ASF GitHub Bot commented on TIKA-4882:
--------------------------------------
tballison commented on code in PR #3142:
URL: https://github.com/apache/tika/pull/3142#discussion_r3972337518
##########
tika-core/src/main/java/org/apache/tika/io/FilenameUtils.java:
##########
@@ -400,7 +400,7 @@ public static String calculateExtension(Metadata metadata,
String defaultValue)
if (ext != null) {
return ext;
}
- return ".bin";
+ return defaultValue;
Review Comment:
I think it should be.
> FilenameUtils.calculateExtension ignores defaultValue on unknown path
> ---------------------------------------------------------------------
>
> Key: TIKA-4882
> URL: https://issues.apache.org/jira/browse/TIKA-4882
> Project: Tika
> Issue Type: Bug
> Components: core
> Reporter: Tim Grein
> Priority: Minor
>
> FilenameUtils.calculateExtension ignores an unknown extension in the sense
> that the behavior on an unknown extension is not specified in the javadoc and
> it's not explicitly handled. It should probably be either handled or
> explicitly documented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
