[
https://issues.apache.org/jira/browse/TIKA-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133252#comment-18133252
]
ASF GitHub Bot commented on TIKA-5009:
--------------------------------------
tballison commented on PR #3445:
URL: https://github.com/apache/tika/pull/3445#issuecomment-6453776131
nits from :robot:
```
- No CHANGES.txt row. This relaxes a user-facing config requirement, so it
probably deserves one under 4.2.1.
- Test coverage is uneven. The fetcher gets with-project, without-project
and requires-bucket tests. The emitter and iterator only get without-project.
- Examples still set "projectId": "my-gcp-project" in all four
docs/modules/ROOT/examples/pipes-gcs-*.json files. Dropping it from at least
one would show
it's optional.
```
Only thing that matters to me is the CHANGES.txt. Examples are nice to have,
but not necessary. Test coverage... whatever.
> GCS fetcher should allow for optional projectId
> -----------------------------------------------
>
> Key: TIKA-5009
> URL: https://issues.apache.org/jira/browse/TIKA-5009
> Project: Tika
> Issue Type: Improvement
> Reporter: Bartek Ciszkowski
> Priority: Major
>
> The GCS fetcher, emitter, and pipes iterator require projectId, but this
> doesn't seem to be required. These plugins read, write, and list objects in a
> specified bucket.
> The java client also does not require projectId, and a comment within it
> states "Project ID is only required for creating buckets, so we don't requite
> it for creating the service."
> [https://github.com/googleapis/google-cloud-java/blob/123f97c3f843dc7a3ff7b4ef0596c1425502a275/java-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageOptions.java#L326]
> Proposal is to make projectId optional in the aforementioned components.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
