dpol1 commented on PR #3451: URL: https://github.com/apache/tika/pull/3451#issuecomment-6492963983
> So, should I update this PR to follow the pattern with oneof() in #2961? Yes, if it keeps what your Values had: the declared type and the original strings. #2961 (I worked on it) drops the type when one value fails to convert, so `extended-properties:TotalTime` arrives as int64 from a .doc and as plain strings from an .odt (`PT1M7S`). It also turns zone-less dates into UTC. Keeping `values` and `type` next to the oneof would cover both, at the cost of sending typed keys twice. wdyt? ParseBytes fits as the "Later" RPC in your design. Two things here, from the code (not run): https://github.com/apache/tika/blob/6480d6f333656e2f693b60d6b27e5600c10a9202/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/FetchParseRuntime.java#L138-L139 - No emit strategy, so with the default DYNAMIC a result of 100 kB or more goes to the empty `EmitKey` and fails. PASSBACK_ALL, as tika-server does, fixes v1 and v2alpha1. - `SKIP` returns no documents when the container throws. /rmeta uses EMIT and returns what was parsed plus the stack trace. Should v2alpha1 match it? #2961 and #3449 have the same SKIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
