Antonio Petrelli wrote:
Hi all!
I noticed that, in Tiles codebase, when a String constant is used as a
init parameter containing a class name:
* in TilesContainerFactory, it is the base class/interface name in
upper-case-underscore-separated, like in
"org.apache.tiles.CONTAINER_FACTORY";
* in DefinitionsFactory, it is the bas class/interface name itself.

To make things homogeneous, what style do you prefer?
From my POV, it is best to use the base class/interface name.

I think there are two different kinds of configuration. One which specifies a class which implements an interface. For this, I agree that the config parameter should be the interface name.

The second provides configuration for an implementation class to use. I'm assuming these are out of scope of this discussion, but I'd assume that they are namespaced in some way so that they can be reused across implementations that would have similar config.

David

Antonio

Reply via email to