2008/3/27, Greg Reddin <[EMAIL PROTECTED]>: > > On Thu, Mar 27, 2008 at 2:54 AM, Antonio Petrelli > <[EMAIL PROTECTED]> wrote: > > 4) Add a wiki page to show how it works: > > http://cwiki.apache.org/TILES/ > > > I agree with the above. I bet we could accept the patch without the > wiki page, but we certainly do need documentation about how it works.
+1. I'm sorry, I meant: after all of the above, it would be nice if you write a wiki page to show how to use it. > > Currently it is a separate factory, with the createDefinitions() > > > method overridden. > > > I think this WildcardDefinitions should be used by the > URLDefFactory > > > by default. > > > > Mmm... I am -1 for this, since it adds some extra complexity. I think > > that it is simply a matter of configuration in web.xml. I know that > > this means that many people can access a feature that they do not know > > to have :-) but I think that a good documentation could be enough. > > > I'm torn on that one. The functionality seems useful enough to > activate it by default. But I can understand the complexity issue. Is > there a "less-complex" way to add it to the base configuration system? I don't think so, Cserveny did a good job in finding the right point of the intervention. Is there a reason a user might want the functionality to *not* be > enabled? The reason is the XWork dependency. If it will be removed, then I think that it could be used as a default. If xwork is needed it's not a problem to include it. It's > ASL-licensed. XWork has an ASL-compatible license, but not ASL: http://www.opensymphony.com/xwork/license.action My doubts are about the inclusion of this dependency because it is a new dependency, its license is OK. One more problem is that we cannot include XWork code and strip out the XWork header. Paul Benedict had a similar issue with Struts and Spring code, and the Legal team of ASF told him to put both Apache and Spring headers on top of source code. Anyway, in this case, we can ask the Struts/XWork team about licensing terms/ source headers. Antonio
