[ 
https://issues.apache.org/jira/browse/TINKERPOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307735#comment-15307735
 ] 

ASF GitHub Bot commented on TINKERPOP-1298:
-------------------------------------------

Github user okram commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/323#discussion_r65182884
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoMapper.java
 ---
    @@ -295,6 +296,7 @@ private void validate() {
                 add(Triplet.<Class, Function<Kryo, Serializer>, 
Integer>with(UUID.class, kryo -> new UUIDSerializer(), 17));
                 add(Triplet.<Class, Function<Kryo, Serializer>, 
Integer>with(URI.class, kryo -> new URISerializer(), 72));
                 add(Triplet.<Class, Function<Kryo, Serializer>, 
Integer>with(VertexTerminator.class, null, 13));
    +            add(Triplet.<Class, Function<Kryo, Serializer>, 
Integer>with(AbstractMap.SimpleEntry.class, kryo -> new EntrySerializer(), 
120)); // ***LAST ID***
    --- End diff --
    
    We already have:
    
    
https://github.com/apache/incubator-tinkerpop/blob/741ca40269203ee4bf7f53f960575415f4b8a121/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoMapper.java#L282
    
    Can you simply use that?


> Save OLAP results to file
> -------------------------
>
>                 Key: TINKERPOP-1298
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1298
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: io, process
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>
> Provide a way to save (tabular) results to text files, just like Spark's 
> {{saveAsTextFile}}.
> I'm not sure about the best way to do it. 3 options come to my mind:
> # a new step.
> # a {{VertexProgram}}
> # a configuration option
> Things to consider / open questions:
> * Is it sufficient to simply {{toString()}} all values or should we allow 
> formatters / format stings?
> * [~jlewandowski] pointed out that it would be nice to have support for the 
> [parquet file format|https://parquet.apache.org/]. I guess now we're already 
> talking about support for different {{FileOutputFormats}} and not just 
> formatters.
> * Is that only relevant for OLAP?
> * Can we support arbitrary file systems?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to