[ 
https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331676#comment-15331676
 ] 

ASF GitHub Bot commented on TINKERPOP-1320:
-------------------------------------------

Github user okram commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/336#discussion_r67155745
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoWriter.java
 ---
    @@ -131,7 +131,7 @@ public void writeVertexProperty(final OutputStream 
outputStream, final VertexPro
         public void writeProperty(final OutputStream outputStream, final 
Property p) throws IOException {
             final Output output = new Output(outputStream);
             writeHeader(output);
    -        kryo.writeObject(output, DetachedFactory.detach(p, true));
    --- End diff --
    
    Is there any way that this may lead to a serialization format that is not 
backwards compatible?


> GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
> ------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1320
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1320
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: test-suite
>    Affects Versions: 3.2.0-incubating, 3.1.2-incubating
>            Reporter: Jason Plurad
>            Assignee: Jason Plurad
>            Priority: Minor
>             Fix For: 3.1.3, 3.2.1
>
>
> This is similar to TINKERPOP-1317. The differences here are
> * The {{TestHelper.generateTempFileFromResource()}} call to load the resource 
> is happening from the {{public static void init()}} method before a graph 
> instance is available.
> * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still 
> required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to