Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/351#discussion_r68934451
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONMapper.java
 ---
    @@ -60,47 +61,78 @@
         private final boolean normalize;
         private final boolean embedTypes;
         private final GraphSONVersion version;
    +    private final TypeInfo typeInfo;
     
         private GraphSONMapper(final List<SimpleModule> customModules, final 
boolean loadCustomSerializers,
    --- End diff --
    
    Could you please make the constructor match this approach:
    
    
https://github.com/apache/tinkerpop/blob/5395aaeb057e4c163233aa8ace2a2975ea827fe5/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoMapper.java#L165-L172
    
    rather than pass the individual parameters we just pass the `Bulider` 
object. Not sure why this wasn't changed already for `GraphSONMapper`.....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to