[ 
https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355240#comment-15355240
 ] 

ASF GitHub Bot commented on TINKERPOP-1274:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/351
  
    Note that travis isn't happy - tests are failing:
    
    ```text
    Failed tests: 
      
GraphSONMessageSerializerV2d0Test.shouldSerializeToJsonIteratorNullElement:147 
expected:<[x]> but was:<[]>
      GraphSONMessageSerializerV2d0Test.shouldSerializeToJsonMap:171 
expected:<[x]> but was:<[]>
      GraphSONMessageSerializerV2d0Test.shouldSerializeToJsonIterable:107 
expected:<[x]> but was:<[]>
      GraphSONMessageSerializerV2d0Test.shouldSerializeToJsonIterator:126 
expected:<[x]> but was:<[]>
    ```
    
    Also - some documentation odds and ends:
    
    * Please update CHANGELOG with an entry for "Introduced GraphSON 2.0". 
    * We probably need o include some reference documentation 
[here](https://github.com/apache/tinkerpop/blob/5395aaeb057e4c163233aa8ace2a2975ea827fe5/docs/src/reference/the-graph.asciidoc#graphson-readerwriter)
 - not sure what that should look like at the moment. We default to 1.0 still 
for now, so we probably don't need to change too much. Perhaps we need a 
section that shows what 2.0 format looks like and how to generate it? Maybe 
that is enough?
    * We need upgrade docs for users so they are aware of this new feature - 
[here](https://github.com/apache/tinkerpop/blob/5395aaeb057e4c163233aa8ace2a2975ea827fe5/docs/src/upgrade/release-3.2.x-incubating.asciidoc#upgrading-for-users)
    * We need upgrade docs for driver devs (need to add a section - no changes 
in 3.2.1 have affected drivers yet) so they are aware of how they might benefit 
from this change - 
[here](https://github.com/apache/tinkerpop/blob/5395aaeb057e4c163233aa8ace2a2975ea827fe5/docs/src/upgrade/release-3.2.x-incubating.asciidoc#upgrading-for-providers)


> GraphSON Version 2.0
> --------------------
>
>                 Key: TINKERPOP-1274
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1274
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 3.1.2-incubating
>            Reporter: stephen mallette
>            Priority: Minor
>             Fix For: 3.2.1
>
>
> Develop a revised version of GraphSON that provides better support for 
> non-JVM languages that consume it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to