GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/354
TINKERPOP-1354 Added more invalid binding keys to Gremlin Server validation
https://issues.apache.org/jira/browse/TINKERPOP-1354
These "invalid" keys are reserved terms for Gremlin Server as they are
statically imported enums and shouldn't be used as binding keys. You get some
less than easy to understand error messages if those keys are used.
I would have CTR'd but wanted to see if anyone had other suggestions for
additional validations at play. Also, this change is "breaking" in the sense
that users who were somehow successfully using some of these newly reserved
keys on previous versions (not fully sure if that was even possible) will have
to update their code. I don't think this is a massive problem for someone to
fix, so while "breaking" it doesn't seem massively detrimental and shouldn't be
widely problematic.
Builds with `mvn clean install -DskipTests && mvn verify -pl gremlin-server
-DskipIntegrationTests=false`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1354
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/354.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #354
----
commit c37c3016bd05b3caeb09084f5469c606c439bfe5
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-06-30T17:07:44Z
Added more invalid binding keys to Gremlin Server OpProcessor validation.
These "invalid" keys are reserved terms for Gremlin Server as they are
statically imported enums and shouldn't be used as binding keys. You get some
less than easy to understand error messages if those keys are used.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
