[ 
https://issues.apache.org/jira/browse/TINKERPOP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422761#comment-15422761
 ] 

ASF GitHub Bot commented on TINKERPOP-1405:
-------------------------------------------

GitHub user twilmes opened a pull request:

    https://github.com/apache/tinkerpop/pull/381

    TINKERPOP-1405 - profile() doesn't like withPath()

    Fixed a small bug in `StandardVerificationStrategy` that caused 
verification to fail when `withPath` was used in conjunction with 
`ProfileStep`.  Updated `StandardVerificationStrategyTest` to test traversals 
with `ProfileStep` and added a test to confirm verification failed on a 
reducing barrier nested within a repeat while I was at it.
    
    This issue did not arise in TP31 so I took a look and the TP31 
`StandardVerificationStrategy` does not have the `ProfileStep` and some other 
verification verification logic in it that is in master.  Because of this, I 
pointed this PR only at master but can re-point to TP31 and add the profile 
step verification in if you guys think that makes sense.
    
    The Travis build appears to have stalled out while downloading artifacts.  
Tests passed local with `mvn clean install`
    
    ```
    [INFO] 
------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] 
------------------------------------------------------------------------
    [INFO] Total time: 24:25 min
    [INFO] Finished at: 2016-08-16T08:43:01-05:00
    [INFO] Final Memory: 140M/843M
    [INFO] 
------------------------------------------------------------------------
    ```
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1405

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #381
    
----
commit 226d83e903dc16f5d6da644d7069bb1b54c3878b
Author: Ted Wilmes <twil...@gmail.com>
Date:   2016-08-16T13:04:28Z

    TINKERPOP-1405 Fixed a small bug in StandardVerificationStrategy that 
caused verification to fail when withPath was used in conjunction with 
ProfileStep.

----


> profile() doesn't like withPath()
> ---------------------------------
>
>                 Key: TINKERPOP-1405
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1405
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.1
>            Reporter: Daniel Kuppitz
>            Assignee: Ted Wilmes
>             Fix For: 3.2.2
>
>
> {{profile()}} fails when used in conjunction with {{withPath()}}:
> {code}
> gremlin> g.withPath().V().profile()
> When specified, the profile()-Step must be the last step or followed only by 
> the cap()-step.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to