[ https://issues.apache.org/jira/browse/TINKERPOP-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497515#comment-15497515 ]
ASF GitHub Bot commented on TINKERPOP-1437: ------------------------------------------- Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/426#discussion_r79258319 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupTest.java --- @@ -73,6 +77,40 @@ public abstract Traversal<Vertex, String> get_g_V_both_both_dedup_byXoutE_countX_name(); + public abstract Traversal<Vertex, String> get_g_V_out_in_valuesXnameX_fold_dedupXlocalX_unfold(); + + public abstract Traversal<Vertex, Map<String, String>> get_g_V_out_in_asXxX_in_asXyX_selectXx_yX_byXnameX_fold_dedupXlocal_x_yX_unfold(); + + @Test + @LoadGraphWith(MODERN) + public void g_V_out_in_valuesXnameX_fold_dedupXlocalX_unfold() { + final Traversal<Vertex, String> traversal = get_g_V_out_in_valuesXnameX_fold_dedupXlocalX_unfold(); + final List<String> names = traversal.toList(); + assertEquals(3, names.size()); + assertThat(names, containsInAnyOrder("marko", "josh", "peter")); + } + + @Test + @LoadGraphWith(MODERN) + public void g_V_out_in_asXxX_in_asXyX_selectXx_yX_byXnameX_fold_dedupXlocal_x_yX_unfold() { --- End diff -- This has a bad method name --- see my other comment and then fix it here too. > Add tests for dedup(Scope) in DedupTest > --------------------------------------- > > Key: TINKERPOP-1437 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1437 > Project: TinkerPop > Issue Type: Improvement > Components: test-suite > Affects Versions: 3.1.4 > Reporter: stephen mallette > Priority: Minor > > There are no tests in the test suite that exercise: > {code} > public default GraphTraversal<S, E> dedup(final Scope scope, final String... > dedupLabels) { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)