[ 
https://issues.apache.org/jira/browse/TINKERPOP-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529919#comment-15529919
 ] 

ASF GitHub Bot commented on TINKERPOP-944:
------------------------------------------

Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/436
  
    VOTE +1


> Deprecate Graph.Exceptions.elementNotFound
> ------------------------------------------
>
>                 Key: TINKERPOP-944
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-944
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: structure
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>             Fix For: 3.2.3
>
>
> As it sits right now, the standard {{elementNotFound}} exception is not used 
> in the core code base, but we are validating that it is being thrown in the 
> test suite by providers!  The test is actually faulty because it is not 
> asserting the message and just that it is a {{NoSuchElementException}} which 
> is causing the problem.  We should either deprecate this method and just 
> validate {{NoSuchElementException}} or use it in full and force providers to 
> do the same.  
> This has the potential to be a breaking change as it might break tests if 
> providers aren't using that standard exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to