GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/441

    TINKERPOP-1467 Corrected a number of problems in close() operations for the 
driver [tp31]

    https://issues.apache.org/jira/browse/TINKERPOP-1467
    
    This was more of a commit than I wanted for `tp31`, but `close()` was 
really messed up. Fixed a number of race conditions and other logic that would 
allow the driver to hang on close. Also made it so that the `Cluster` makes an 
attempt to clean up any `Client` instances that it spawns.
    
    Tested with `mvn clean install` and endlessly with `mvn verify -pl 
gremlin-server -DskipIntegrationTests=false` (basically ran it for a whole day 
over and over again).
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1467

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #441
    
----
commit c3acce6e0a8c9270a10ed0eb4f3fd3f46539a655
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-09-28T15:06:14Z

    Corrected a number of problems in close() operations for the driver.
    
    This was more of a commit than I wanted for tp31, but close() was really 
messed up. Fixed a number of race conditions and other logic that would allow 
the driver to hang on close. Also made it so that the Cluster makes an attempt 
to clean up any Client instances that it spawns.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to