[
https://issues.apache.org/jira/browse/TINKERPOP-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530638#comment-15530638
]
ASF GitHub Bot commented on TINKERPOP-1467:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/441
TINKERPOP-1467 Corrected a number of problems in close() operations for the
driver [tp31]
https://issues.apache.org/jira/browse/TINKERPOP-1467
This was more of a commit than I wanted for `tp31`, but `close()` was
really messed up. Fixed a number of race conditions and other logic that would
allow the driver to hang on close. Also made it so that the `Cluster` makes an
attempt to clean up any `Client` instances that it spawns.
Tested with `mvn clean install` and endlessly with `mvn verify -pl
gremlin-server -DskipIntegrationTests=false` (basically ran it for a whole day
over and over again).
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1467
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #441
----
commit c3acce6e0a8c9270a10ed0eb4f3fd3f46539a655
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-28T15:06:14Z
Corrected a number of problems in close() operations for the driver.
This was more of a commit than I wanted for tp31, but close() was really
messed up. Fixed a number of race conditions and other logic that would allow
the driver to hang on close. Also made it so that the Cluster makes an attempt
to clean up any Client instances that it spawns.
----
> Improve close() operations on the Java driver
> ----------------------------------------------
>
> Key: TINKERPOP-1467
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1467
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
> Affects Versions: 3.1.3
> Reporter: stephen mallette
> Assignee: stephen mallette
> Fix For: 3.1.5, 3.2.3
>
>
> A few big problems:
> 1. Client will hang if submitting a request after {{close()}}
> 2. Multiple calls to {{close()}} hangs periodically
> 3. Closing the {{Cluster}} doesn't attempt to clean up open {{Client}}
> instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
