Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/440
  
    First of all, thanks for taking the time to do this. 
[TINKERPOP-1044](https://issues.apache.org/jira/browse/TINKERPOP-1044) was less 
about REST and more about the Gremlin Server protocol but as it turns out the 
issue is the same in REST as it is over there.  
    
    > there should be some common response between all channelizer methods that 
is defined in only one location
    
    There's no such place to do that. There isn't any shared exception 
processing logic between REST and the Gremlin Server protocol. I think you 
would add that logic here:
    
    
https://github.com/apache/tinkerpop/blob/850e159b8dc883ac3995c8d775b8f09b7a64b440/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java#L260-L266
    
    as i look at it now the error messaging logic is a bit weird there to begin 
with (i.e. if we don't have an "error message" we just use the class simple 
name?? - no idea why that is like that). Note that there are a number of 
integration tests that may fail if with these changes you are making as they 
rely on the asserting error messages in some cases. If you haven't done so 
already please be sure to run those tests:
    
    ```text
    mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false
    ```
    
    Also, please add an entry to the CHANGELOG that describes your fix:
    
    
https://github.com/apache/tinkerpop/blob/850e159b8dc883ac3995c8d775b8f09b7a64b440/CHANGELOG.asciidoc#tinkerpop-323-release-date-not-officially-released-yet


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to